I have dowloaded a paid app, turned on family sharing, listed my daughter but when she accessed the app it is only trial version on her ipad, is that how it really works
For most app subscriptions yes as they cannot be shared. Only the direct App purchases can be shared.
See here: link-> What types of content can I share with my family? - Apple Support